Skip to content

Revert "Adjusted the configuration of Maven. (#532)"#536

Merged
artursouza merged 1 commit into
dapr:masterfrom
artursouza:revert_pom_refactoring
Apr 30, 2021
Merged

Revert "Adjusted the configuration of Maven. (#532)"#536
artursouza merged 1 commit into
dapr:masterfrom
artursouza:revert_pom_refactoring

Conversation

@artursouza

@artursouza artursouza commented Apr 30, 2021

Copy link
Copy Markdown
Contributor

This reverts commit 5cc7981.

Description

Reverting since this change caused release to skip deploying artifacts:

1338[INFO] --- maven-deploy-plugin:2.7:deploy (default-deploy) @ dapr-sdk-springboot --- 
1339[INFO] Skipping artifact deployment 
1340[INFO] ------------------------------------------------------------------------ 
1341[INFO] Reactor Summary for dapr-sdk-parent 1.1.0-SNAPSHOT: 
1342[INFO] 
1343[INFO] dapr-sdk-parent .................................... SUCCESS [ 1.011 s] 
1344[INFO] dapr-sdk-autogen ................................... SUCCESS [ 3.947 s] 
1345[INFO] dapr-sdk ........................................... SUCCESS [ 9.805 s] 
1346[INFO] dapr-sdk-actors .................................... SUCCESS [ 7.481 s] 
1347[INFO] dapr-sdk-springboot ................................ SUCCESS [ 0.340 s] 
1348[INFO] ------------------------------------------------------------------------ 
1349[INFO] BUILD SUCCESS 
1350[INFO] ------------------------------------------------------------------------ 
1351[INFO] Total time: 22.864 s 
1352[INFO] Finished at: 2021-04-29T23:54:46Z 
1353[INFO] -----------------------------------------------------------------------

Issue reference

We strive to have all PR being opened based on an issue, where the problem or feature have been discussed prior to implementation.

This will reopen: #531

Checklist

Please make sure you've completed the relevant tasks for this PR, out of the following list:

  • Code compiles correctly
  • Created/updated tests
  • Extended the documentation

@codecov

codecov Bot commented Apr 30, 2021

Copy link
Copy Markdown

Codecov Report

Merging #536 (449dfe2) into master (5cc7981) will decrease coverage by 0.13%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #536      +/-   ##
============================================
- Coverage     80.65%   80.52%   -0.14%     
+ Complexity      982      981       -1     
============================================
  Files            88       88              
  Lines          3024     3024              
  Branches        331      331              
============================================
- Hits           2439     2435       -4     
- Misses          420      423       +3     
- Partials        165      166       +1
Impacted Files Coverage Δ Complexity Δ
sdk/src/main/java/io/dapr/utils/Retry.java 50.00% <0.00%> (-25.00%) 1.00% <0.00%> (-1.00%)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5cc7981...449dfe2. Read the comment docs.

@artursouza artursouza merged commit 7467575 into dapr:master Apr 30, 2021
fackee pushed a commit to fackee/java-sdk that referenced this pull request Mar 28, 2022
@artursouza
Revert "Adjusted the configuration of Maven. (dapr#532)" (dapr#536)
8608f34 
This reverts commit 5cc7981.

Signed-off-by: zjx244729 <zjx244729@alibaba-inc.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer
@mukundansundar mukundansundar mukundansundar approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@artursouza @mukundansundar